chore: [Orchestration] Add warning for incompatible API usage #627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jonas-Isr
reviewed
Oct 22, 2025
Comment on lines
+85
to
+88
| val JSON_SCHEMA = "https://json-schema.org/draft/2020-12/schema"; | ||
| if (t.text().contains(JSON_SCHEMA) && config.getTemplateConfig() != null) { | ||
| log.warn("Combination of `entity(...)` and `withTemplateConfig(...)` is not supported."); | ||
| } |
Member
There was a problem hiding this comment.
I am not sure if testing just for https://json-schema.org/draft/2020-12/schema is good here. This might lead to false positives if a users specifies the schema version in their actual prompt (not sure how likely it is, but might happen?!)
I would thus add a bit of the formatting around it to the test string.
Suggested change
| val JSON_SCHEMA = "https://json-schema.org/draft/2020-12/schema"; | |
| if (t.text().contains(JSON_SCHEMA) && config.getTemplateConfig() != null) { | |
| log.warn("Combination of `entity(...)` and `withTemplateConfig(...)` is not supported."); | |
| } | |
| val JSON_SCHEMA = "\\n \\\"$schema\\\" : \\\"https://json-schema.org/draft/2020-12/schema\\\","; | |
| if (t.text().contains(JSON_SCHEMA) && config.getTemplateConfig() != null) { | |
| log.warn("Combination of `entity(...)` and `withTemplateConfig(...)` is not supported."); | |
| } |
Contributor
Author
There was a problem hiding this comment.
Likely we shouldn't put this in OrchestrationClient altogether. If we put this into code, it'd be better located in Spring AI related class(es) 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Related
Considering a warn message, since we cannot enforce it via API design with the existing code.
Feature scope:
.entity(..)+ Orchestration.withTemplateConfig(..)Definition of Done
Tests cover the scope aboveError handling created / updated & covered by the tests aboveAligned changes with the JavaScript SDKDocumentation updatedRelease notes updated